Patchwork [1,of,2,V2,stable] run-tests: produce error on running a failing test

login
register
mail settings
Submitter Anurag Goel
Date June 11, 2014, 8:17 p.m.
Message ID <45d558694c2688545242.1402517852@ubuntu.ubuntu-domain>
Download mbox | patch
Permalink /patch/4975/
State Accepted
Commit 5ee547fdb0be67ed97eb737d5feda2932d3dfb93
Headers show

Comments

Anurag Goel - June 11, 2014, 8:17 p.m.
# HG changeset patch
# User anuraggoel <anurag.dsps@gmail.com>
# Date 1402517217 -19800
#      Thu Jun 12 01:36:57 2014 +0530
# Node ID 45d558694c2688545242502651c842de4388ca04
# Parent  9fd0c7b9c9442dfc5f9a8f9ce2404e0f2fa8f271
run-tests: produce error on running a failing test

This patch fixes a regression recently introduced by a refactoring.
It produce an error message everytime with a test filename which gets fail
while testing except at one condition when '--nodiff' option is enabled.
Pierre-Yves David - June 12, 2014, 3:01 a.m.
On 06/11/2014 07:52 PM, Kevin Bullock wrote:
> On Jun 11, 2014, at 3:17 PM, Anurag Goel <anurag.dsps@gmail.com> wrote:
>
>> # HG changeset patch
>> # User anuraggoel <anurag.dsps@gmail.com>
>> # Date 1402517217 -19800
>> #      Thu Jun 12 01:36:57 2014 +0530
>> # Node ID 45d558694c2688545242502651c842de4388ca04
>> # Parent  9fd0c7b9c9442dfc5f9a8f9ce2404e0f2fa8f271
>> run-tests: produce error on running a failing test
>>
>> This patch fixes a regression recently introduced by a refactoring.
>> It produce an error message everytime with a test filename which gets fail
>> while testing except at one condition when '--nodiff' option is enabled.
>
> Looking good, but Pierre-Yves forgot to tell you that it's good practice to reference in the commit message what changeset actually broke things. Could you track that down?

Greg got about 200 changesets in for this refactoring. And a lot of them 
introduce code behind a config flag. This is usually a good practice but 
I would relax it in the current case.

Patch

diff -r 9fd0c7b9c944 -r 45d558694c26 tests/run-tests.py
--- a/tests/run-tests.py	Thu Jun 12 01:34:29 2014 +0530
+++ b/tests/run-tests.py	Thu Jun 12 01:36:57 2014 +0530
@@ -1075,6 +1075,9 @@ 
 
         if self._options.first:
             self.stop()
+        else:
+            if not self._options.nodiff:
+                self.stream.write('\nERROR: %s output changed\n' % test)
 
     def addError(self, *args, **kwargs):
         super(TestResult, self).addError(*args, **kwargs)