Patchwork D11381: rhg: fallback if `defaults` config is set for the current command

login
register
mail settings
Submitter phabricator
Date Sept. 1, 2021, 4:43 p.m.
Message ID <differential-rev-PHID-DREV-55o3jn3vgsleka6ugv3r-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49697/
State New
Headers show

Comments

phabricator - Sept. 1, 2021, 4:43 p.m.
Alphare created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D11381

AFFECTED FILES
  rust/rhg/src/main.rs
  tests/test-rhg.t

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-rhg.t b/tests/test-rhg.t
--- a/tests/test-rhg.t
+++ b/tests/test-rhg.t
@@ -225,6 +225,12 @@ 
   unsupported feature: fail-cat hook defined
   [252]
 
+Fallback with [defaults]
+  $ $NO_FALLBACK rhg cat original --config "defaults.cat=-r null"
+  unsupported feature: `defaults` config set
+  [252]
+
+
 Requirements
   $ $NO_FALLBACK rhg debugrequirements
   dotencode
diff --git a/rust/rhg/src/main.rs b/rust/rhg/src/main.rs
--- a/rust/rhg/src/main.rs
+++ b/rust/rhg/src/main.rs
@@ -69,6 +69,14 @@ 
 
     let (subcommand_name, subcommand_matches) = matches.subcommand();
 
+    // Mercurial allows users to define "defaults" for commands, fallback
+    // if a default is detected for the current command
+    let defaults = config.get_str(b"defaults", subcommand_name.as_bytes());
+    if defaults?.is_some() {
+        let msg = "`defaults` config set";
+        return Err(CommandError::unsupported(msg));
+    }
+
     for prefix in [&"pre", &"post", &"fail"].iter() {
         // Mercurial allows users to define generic hooks for commands,
         // fallback if any are detected