Patchwork D11360: pyoxidizer: default to a meaningless release instead of hardcoding 5.8

login
register
mail settings
Submitter phabricator
Date Aug. 27, 2021, 12:41 p.m.
Message ID <differential-rev-PHID-DREV-jrqktdrjok7bmhn6pd2w-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49675/
State New
Headers show

Comments

phabricator - Aug. 27, 2021, 12:41 p.m.
Alphare created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This way we don't advertise the wrong version, or if we do it's really obvious.
  To be honest, I'm not even sure that `VERSION` should be optional, but I also
  have never used the packaging tools so far, this is simply something I saw.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D11360

AFFECTED FILES
  rust/hgcli/pyoxidizer.bzl

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/rust/hgcli/pyoxidizer.bzl b/rust/hgcli/pyoxidizer.bzl
--- a/rust/hgcli/pyoxidizer.bzl
+++ b/rust/hgcli/pyoxidizer.bzl
@@ -24,7 +24,7 @@ 
 
 ROOT = CWD + "/../.."
 
-VERSION = VARS.get("VERSION", "5.8")
+VERSION = VARS.get("VERSION", "0.0")
 MSI_NAME = VARS.get("MSI_NAME", "mercurial")
 EXTRA_MSI_FEATURES = VARS.get("EXTRA_MSI_FEATURES")
 SIGNING_PFX_PATH = VARS.get("SIGNING_PFX_PATH")