D11309: check-code: drop the camelcase checks

Submitter	phabricator
Date	Aug. 19, 2021, 6:12 p.m.
Message ID	<differential-rev-PHID-DREV-zj47xgjzvwg4i26ch274-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/49623/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 19 Aug 2021 18:12:23 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "marmoute (Pierre-Yves David)" <phabricator@mercurial-scm.org> Subject: D11309: check-code: drop the camelcase checks Message-ID: <differential-rev-PHID-DREV-zj47xgjzvwg4i26ch274-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-zj47xgjzvwg4i26ch274 Thread-Index: M2M0MTIwMjZlNjBlYzI4YWU0NjE1ZTc3ODE0 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "marmoute \(Pierre-Yves David\)" <phabricator+D11309+public+93f0f182f842b83f@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Aug. 19, 2021, 6:12 p.m.

marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  Fro about 2 years we have been using CamelCase is class names. That rules gets
  in the way of assigning class or exception in compatibility layers.
  
  I think it is safe to drop it now that we started using CamelCase for some case.
  
  My motivation for this is the need to assign `FileNotFoundError` in `pycompat`.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D11309

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -340,11 +340,6 @@ 
         (r'[^\n]\Z', "no trailing newline"),
         (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
         (
-            r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',
-            "don't use camelcase in identifiers",
-            r'#.*camelcase-required',
-        ),
-        (
             r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
             "linebreak after :",
         ),

Patchwork D11309: check-code: drop the camelcase checks

Comments

Patch