Patchwork D11304: pyoxidizer: disable the test for disabled & broken extensions help

login
register
mail settings
Submitter phabricator
Date Aug. 18, 2021, 7:48 p.m.
Message ID <differential-rev-PHID-DREV-nlng5c3jii3gxx6aylwb-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49618/
State Superseded
Headers show

Comments

phabricator - Aug. 18, 2021, 7:48 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The test is a bit fragile and the feature is significantly broken for 3rd party
  extension already. So we disable that section with a comment about why and what
  is needed.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D11304

AFFECTED FILES
  tests/test-extension.t

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-extension.t b/tests/test-extension.t
--- a/tests/test-extension.t
+++ b/tests/test-extension.t
@@ -1378,6 +1378,18 @@ 
   (use 'hg help extensions' for information on enabling extensions)
 
 
+Help can find unimported extensions
+-----------------------------------
+
+XXX-PYOXIDIZER since the frozen binary does not have source directory tree,
+this make the checking for actual file under `hgext` a bit complicated. In
+addition these tests do some strange dance to ensure some other module are the
+first in `sys.path` (since the current install path is always in front
+otherwise) that are fragile and that does not match reality in the field. So
+for now we disable this test untill a deeper rework of that logic is done.
+
+#if no-pyoxidizer
+
 Broken disabled extension and command:
 
   $ mkdir hgext
@@ -1413,6 +1425,10 @@ 
   (try 'hg help --keyword foo')
   [255]
 
+#endif
+
+---
+
   $ cat > throw.py <<EOF
   > from mercurial import commands, registrar, util
   > cmdtable = {}