Patchwork D11257: pager: account for flakiness in Windows output

login
register
mail settings
Submitter phabricator
Date Aug. 5, 2021, 4:26 p.m.
Message ID <differential-rev-PHID-DREV-w7yeoexlu6lxx4oyos7s-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49571/
State Superseded
Headers show

Comments

phabricator - Aug. 5, 2021, 4:26 p.m.
Alphare created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This test case is cursed and probably not worth losing more time over. This
  makes apparent what the intended behavior is while still removing the flakiness
  from the CI.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D11257

AFFECTED FILES
  tests/test-pager.t

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -219,26 +219,26 @@ 
 #endif
 
 A complicated pager command gets worse behavior. Bonus points if you can
-improve this. Windows apparently does this better?
+improve this. Windows apparently does this better, but only sometimes?
 #if windows
   $ hg log --limit 3 \
   >   --config pager.pager='this-command-better-never-exist --seriously' \
   >  2>/dev/null || true
-  \x1b[0;33mchangeset:   10:46106edeeb38\x1b[0m (esc)
-  tag:         tip
-  user:        test
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  summary:     modify a 10
-  
-  \x1b[0;33mchangeset:   9:6dd8ea7dd621\x1b[0m (esc)
-  user:        test
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  summary:     modify a 9
-  
-  \x1b[0;33mchangeset:   8:cff05a6312fe\x1b[0m (esc)
-  user:        test
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  summary:     modify a 8
+  \x1b[0;33mchangeset:   10:46106edeeb38\x1b[0m (esc) (?)
+  tag:         tip (?)
+  user:        test (?)
+  date:        Thu Jan 01 00:00:00 1970 +0000 (?)
+  summary:     modify a 10 (?)
+   (?)
+  \x1b[0;33mchangeset:   9:6dd8ea7dd621\x1b[0m (esc) (?)
+  user:        test (?)
+  date:        Thu Jan 01 00:00:00 1970 +0000 (?)
+  summary:     modify a 9 (?)
+   (?)
+  \x1b[0;33mchangeset:   8:cff05a6312fe\x1b[0m (esc) (?)
+  user:        test (?)
+  date:        Thu Jan 01 00:00:00 1970 +0000 (?)
+  summary:     modify a 8 (?)
   
 #else
   $ hg log --limit 3 \