Patchwork D11220: store: document the decoding discrepancy in store.py

login
register
mail settings
Submitter phabricator
Date July 27, 2021, 8:15 p.m.
Message ID <differential-rev-PHID-DREV-2odi2kqt5sxhafl4lo7l-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49534/
State Superseded
Headers show

Comments

phabricator - July 27, 2021, 8:15 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This will help future people that might be looking into this.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D11220

AFFECTED FILES
  mercurial/store.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/store.py b/mercurial/store.py
--- a/mercurial/store.py
+++ b/mercurial/store.py
@@ -569,6 +569,11 @@ 
         self.vfs = vfsmod.filtervfs(vfs, encodefilename)
         self.opener = self.vfs
 
+    # note: topfiles would also need a decode phase. It is just that in
+    # practice we do not have any file outside of `data/` that needs encoding.
+    # However that might change so we should probably add a test and encoding
+    # decoding for it too. see issue6548
+
     def datafiles(self, matcher=None):
         for t, a, b, size in super(encodedstore, self).datafiles():
             try: