From patchwork Wed Jul 21 20:07:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D11206: typing: convert an annotation to an assertion in commands.py From: phabricator X-Patchwork-Id: 49521 Message-Id: To: Phabricator Cc: mercurial-devel@mercurial-scm.org Date: Wed, 21 Jul 2021 20:07:40 +0000 mharbison72 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Pytype was happy with the annotation at one point, but 2021.04.15 now complains. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11206 AFFECTED FILES mercurial/commands.py CHANGE DETAILS To: mharbison72, #hg-reviewers Cc: mercurial-patches, mercurial-devel diff --git a/mercurial/commands.py b/mercurial/commands.py --- a/mercurial/commands.py +++ b/mercurial/commands.py @@ -3341,7 +3341,8 @@ ) # checking that newnodes exist because old state files won't have it elif statedata.get(b'newnodes') is not None: - nn = statedata[b'newnodes'] # type: List[bytes] + nn = statedata[b'newnodes'] + assert isinstance(nn, list) # list of bytes nn.append(node) # remove state when we complete successfully