Patchwork D11117: dirstate-item: use an explicit __init__ function instead of the attrs one

login
register
mail settings
Submitter phabricator
Date July 19, 2021, 10:38 a.m.
Message ID <differential-rev-PHID-DREV-tpn3i3d424fyh46hx5ap-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49431/
State Superseded
Headers show

Comments

phabricator - July 19, 2021, 10:38 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  For now, this is not doing anything special, however we plan to make it different in the future. So we start simple.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D11117

AFFECTED FILES
  mercurial/pure/parsers.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/pure/parsers.py b/mercurial/pure/parsers.py
--- a/mercurial/pure/parsers.py
+++ b/mercurial/pure/parsers.py
@@ -44,7 +44,7 @@ 
 AMBIGUOUS_TIME = -1
 
 
-@attr.s(slots=True)
+@attr.s(slots=True, init=False)
 class DirstateItem(object):
     """represent a dirstate entry
 
@@ -61,6 +61,12 @@ 
     _size = attr.ib()
     _mtime = attr.ib()
 
+    def __init__(self, state, mode, size, mtime):
+        self._state = state
+        self._mode = mode
+        self._size = size
+        self._mtime = mtime
+
     def __getitem__(self, idx):
         if idx == 0 or idx == -4:
             msg = b"do not use item[x], use item.state"