Patchwork D10964: dirstate: drop the now unused magic constants for the dirstate module

login
register
mail settings
Submitter phabricator
Date July 4, 2021, 9:54 p.m.
Message ID <differential-rev-PHID-DREV-j32maqg6gpokdf6i3mkz-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49277/
State Superseded
Headers show

Comments

phabricator - July 4, 2021, 9:54 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We no longer need them for the dirstate logic. We only need them in the
  dirstate map (and parsers) logic.
  
  This smell like progress.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10964

AFFECTED FILES
  mercurial/dirstate.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -47,15 +47,6 @@ 
 
 dirstatetuple = parsers.dirstatetuple
 
-# a special value used internally for `size` if the file come from the other parent
-FROM_P2 = dirstatemap.FROM_P2
-
-# a special value used internally for `size` if the file is modified/merged/added
-NONNORMAL = dirstatemap.NONNORMAL
-
-# a special value used internally for `time` if the time is ambigeous
-AMBIGUOUS_TIME = dirstatemap.AMBIGUOUS_TIME
-
 
 class repocache(filecache):
     """filecache for files in .hg/"""