Patchwork D10952: dirstate: add a `in_merge` property

login
register
mail settings
Submitter phabricator
Date July 4, 2021, 9:50 p.m.
Message ID <differential-rev-PHID-DREV-oo33dgpsvyjz7qz7c7k2-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49266/
State Superseded
Headers show

Comments

phabricator - July 4, 2021, 9:50 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This factor the "p2 is not null" check and is fairly simpler to read.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10952

AFFECTED FILES
  mercurial/dirstate.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -337,6 +337,11 @@ 
     def p2(self):
         return self._validate(self._pl[1])
 
+    @property
+    def in_merge(self):
+        """True if a merge is in progress"""
+        return self._pl[1] != self._nodeconstants.nullid
+
     def branch(self):
         return encoding.tolocal(self._branch)
 
@@ -513,7 +518,7 @@ 
 
     def normallookup(self, f):
         '''Mark a file normal, but possibly dirty.'''
-        if self._pl[1] != self._nodeconstants.nullid:
+        if self.in_merge:
             # if there is a merge going on and the file was either
             # in state 'm' (-1) or coming from other parent (-2) before
             # being removed, restore that state.
@@ -535,7 +540,7 @@ 
 
     def otherparent(self, f):
         '''Mark as coming from the other parent, always dirty.'''
-        if self._pl[1] == self._nodeconstants.nullid:
+        if not self.in_merge:
             msg = _(b"setting %r to other parent only allowed in merges") % f
             raise error.Abort(msg)
         if f in self and self[f] == b'n':
@@ -556,7 +561,7 @@ 
         self._dirty = True
         oldstate = self[f]
         size = 0
-        if self._pl[1] != self._nodeconstants.nullid:
+        if self.in_merge:
             entry = self._map.get(f)
             if entry is not None:
                 # backup the previous state
@@ -572,7 +577,7 @@ 
 
     def merge(self, f):
         '''Mark a file merged.'''
-        if self._pl[1] == self._nodeconstants.nullid:
+        if not self.in_merge:
             return self.normallookup(f)
         return self.otherparent(f)