Patchwork [05,of,11,FOR-REFERENCE] test-run-tests.t: test running a failing test

login
register
mail settings
Submitter Anurag Goel
Date June 4, 2014, 5:49 p.m.
Message ID <CAMq1dJJrs_nSdcx3EuvCa4oXoNc=bxpS8=jyUQjxjiU9rcyWjw@mail.gmail.com>
Download mbox | patch
Permalink /patch/4926/
State Accepted
Commit 7ec3b32b98bb3a503a88eab867d801ea6fbe1787
Headers show

Comments

Anurag Goel - June 4, 2014, 5:49 p.m.
Following patch fixed the failure test error.
Pierre-Yves David - June 4, 2014, 11:57 p.m.
On 06/04/2014 10:49 AM, Anurag Goel wrote:
> Following patch fixed the failure test error.

Nice. This now needs to be a proper patches with description and sent to 
the list.


>
> diff -r f403482c459a tests/run-tests.py
> --- a/tests/run-tests.py    Wed Jun 04 22:56:41 2014 +0530
> +++ b/tests/run-tests.py    Wed Jun 04 23:10:59 2014 +0530
> @@ -1075,6 +1075,9 @@
>
>           if self._options.first:
>               self.stop()
> +        else:
> +            self.stream.write('\nERROR: %s output changed\n' % test)
> +            self.stream.write('!')
>
>       def addError(self, *args, **kwargs):
>           super(TestResult, self).addError(*args, **kwargs)
>
>
>
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>

Patch

diff -r f403482c459a tests/run-tests.py
--- a/tests/run-tests.py    Wed Jun 04 22:56:41 2014 +0530
+++ b/tests/run-tests.py    Wed Jun 04 23:10:59 2014 +0530
@@ -1075,6 +1075,9 @@ 

         if self._options.first:
             self.stop()
+        else:
+            self.stream.write('\nERROR: %s output changed\n' % test)
+            self.stream.write('!')

     def addError(self, *args, **kwargs):
         super(TestResult, self).addError(*args, **kwargs)