Patchwork [05,of,11,FOR-REFERENCE] test-run-tests.t: test running a failing test

login
register
mail settings
Submitter Pierre-Yves David
Date June 2, 2014, 7:54 p.m.
Message ID <858b3df64bb0a72c055e.1401738880@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/4918/
State Superseded
Commit 7ec3b32b98bb3a503a88eab867d801ea6fbe1787
Headers show

Comments

Pierre-Yves David - June 2, 2014, 7:54 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1401477056 25200
#      Fri May 30 12:10:56 2014 -0700
# Node ID 858b3df64bb0a72c055e44479a53801dfceb5d4f
# Parent  ac5927a3b3f846cff3aebfccf3f7a59c4cec0a83
test-run-tests.t: test running a failing test
Pierre-Yves David - June 2, 2014, 8:10 p.m.
On 06/02/2014 12:54 PM, pierre-yves.david@ens-lyon.org wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1401477056 25200
> #      Fri May 30 12:10:56 2014 -0700
> # Node ID 858b3df64bb0a72c055e44479a53801dfceb5d4f
> # Parent  ac5927a3b3f846cff3aebfccf3f7a59c4cec0a83
> test-run-tests.t: test running a failing test

With the new code, This test fails with the following output:


   diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
   --- a/tests/test-run-tests.t
   +++ b/tests/test-run-tests.t
   @@ -33,12 +33,10 @@ failing test
      +++ $TESTTMP/test-failure.t.err
      @@ -1,2 +1,2 @@
         $ echo babar
      -  rataxes
      +  babar
   -
   -  ERROR: test-failure.t output changed
   -  !.
   +  .
      Failed test-failure.t: output changed
      # Ran 2 tests, 0 skipped, 0 warned, 1 failed.
      python hash seed: * (glob)
      [1]

The "ERROR: test-failure.t output changed" message and the "!" have been 
dropped.

This sounds like regressions that needs fixes to me.



>
> diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
> --- a/tests/test-run-tests.t
> +++ b/tests/test-run-tests.t
> @@ -16,5 +16,29 @@ a succesful test
>     > EOF
>
>     $ $TESTDIR/run-tests.py --with-hg=`which hg`
>     .
>     # Ran 1 tests, 0 skipped, 0 warned, 0 failed.
> +
> +failing test
> +==================
> +
> +  $ cat > test-failure.t << EOF
> +  >   $ echo babar
> +  >   rataxes
> +  > EOF
> +
> +  $ $TESTDIR/run-tests.py --with-hg=`which hg`
> +
> +  --- $TESTTMP/test-failure.t
> +  +++ $TESTTMP/test-failure.t.err
> +  @@ -1,2 +1,2 @@
> +     $ echo babar
> +  -  rataxes
> +  +  babar
> +
> +  ERROR: test-failure.t output changed
> +  !.
> +  Failed test-failure.t: output changed
> +  # Ran 2 tests, 0 skipped, 0 warned, 1 failed.
> +  python hash seed: * (glob)
> +  [1]
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
--- a/tests/test-run-tests.t
+++ b/tests/test-run-tests.t
@@ -16,5 +16,29 @@  a succesful test
   > EOF
 
   $ $TESTDIR/run-tests.py --with-hg=`which hg`
   .
   # Ran 1 tests, 0 skipped, 0 warned, 0 failed.
+
+failing test
+==================
+
+  $ cat > test-failure.t << EOF
+  >   $ echo babar
+  >   rataxes
+  > EOF
+
+  $ $TESTDIR/run-tests.py --with-hg=`which hg`
+  
+  --- $TESTTMP/test-failure.t
+  +++ $TESTTMP/test-failure.t.err
+  @@ -1,2 +1,2 @@
+     $ echo babar
+  -  rataxes
+  +  babar
+  
+  ERROR: test-failure.t output changed
+  !.
+  Failed test-failure.t: output changed
+  # Ran 2 tests, 0 skipped, 0 warned, 1 failed.
+  python hash seed: * (glob)
+  [1]