Patchwork D10820: verify: use some intermediate variables instead of a multi-liner

login
register
mail settings
Submitter phabricator
Date June 1, 2021, 9:55 a.m.
Message ID <differential-rev-PHID-DREV-ax3kgay7lofml54cc7ot-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49140/
State Superseded
Headers show

Comments

phabricator - June 1, 2021, 9:55 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This is shorter and easier to read as the indentation remains the same.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10820

AFFECTED FILES
  mercurial/verify.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -554,15 +554,8 @@ 
                                 self._warn(WARN_UNKNOWN_COPY_SOURCE % (f, ctx))
                         fl2 = repo.file(rp[0])
                         if not len(fl2):
-                            self._err(
-                                lr,
-                                _(
-                                    b"empty or missing copy source revlog "
-                                    b"%s:%s"
-                                )
-                                % (rp[0], short(rp[1])),
-                                f,
-                            )
+                            m = _(b"empty or missing copy source revlog %s:%s")
+                            self._err(lr, m % (rp[0], short(rp[1])), f)
                         elif rp[1] == self.repo.nullid:
                             ui.note(
                                 _(