Patchwork D10812: verify: use some intermediate variables instead of a multi-liner

login
register
mail settings
Submitter phabricator
Date June 1, 2021, 9:54 a.m.
Message ID <differential-rev-PHID-DREV-yhv22zgjmvtq7n2iqpvt-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49132/
State Superseded
Headers show

Comments

phabricator - June 1, 2021, 9:54 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This is shorter and easier to read as the indentation remains the same.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10812

AFFECTED FILES
  mercurial/verify.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -329,11 +329,8 @@ 
             if n in mflinkrevs:
                 del mflinkrevs[n]
             elif dir:
-                self._err(
-                    lr,
-                    _(b"%s not in parent-directory manifest") % short(n),
-                    label,
-                )
+                msg = _(b"%s not in parent-directory manifest") % short(n)
+                self._err(lr, msg, label)
             else:
                 self._err(lr, _(b"%s not in changesets") % short(n), label)