Patchwork D10807: verify: use some intermediate variables instead of a multi-liner

login
register
mail settings
Submitter phabricator
Date June 1, 2021, 9:53 a.m.
Message ID <differential-rev-PHID-DREV-cdnsovfcmrfmktjjc4ck-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49127/
State Superseded
Headers show

Comments

phabricator - June 1, 2021, 9:53 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This is shorter and easier to read as the indentation remains the same.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10807

AFFECTED FILES
  mercurial/verify.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -145,10 +145,9 @@ 
                                 linkrevs.append(lr)
                     except Exception:
                         pass
-                self._warn(
-                    _(b" (expected %s)")
-                    % b" ".join(map(pycompat.bytestr, linkrevs))
-                )
+                msg = _(b" (expected %s)")
+                msg %= b" ".join(map(pycompat.bytestr, linkrevs))
+                self._warn(msg)
             lr = None  # can't be trusted
 
         try: