Patchwork D10702: run-tests: use the same python version for shebang lines on Windows

login
register
mail settings
Submitter phabricator
Date May 8, 2021, 4:30 a.m.
Message ID <differential-rev-PHID-DREV-5liyz3txomgep5ytsaav-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49021/
State Superseded
Headers show

Comments

phabricator - May 8, 2021, 4:30 a.m.
mharbison72 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The latest py3 is used if the minor number isn't specified.  After running the
  script to install all of the build dependencies, that moved the default from 3.8
  to 3.9 on the CI system.  That in turn caused a bunch of tests to be skipped
  that were running prior, even when the test runner was invoked with `py -3.8`.
  While we should almost always use the latest version, we really shouldn't make
  it hard to test different versions or allow things to randomly break in subtle
  ways like that.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10702

AFFECTED FILES
  tests/run-tests.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -3537,7 +3537,7 @@ 
             if os.getenv('MSYSTEM'):
                 with open(osenvironb[b'RUNTESTDIR'] + b'/python3', 'wb') as f:
                     f.write(b'#!/bin/sh\n')
-                    f.write(b'py -3 "$@"\n')
+                    f.write(b'py -3.%d "$@"\n' % sys.version_info[1])
 
             exedir, exename = os.path.split(sysexecutable)
             vlog(