Patchwork D10644: revlog: create a create `null_item` attribute for V0

login
register
mail settings
Submitter phabricator
Date May 4, 2021, 2:18 p.m.
Message ID <differential-rev-PHID-DREV-a2le2x6ygojgs3jscjek-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48961/
State Superseded
Headers show

Comments

phabricator - May 4, 2021, 2:18 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This value is currently wrong, but at least it is now -obviously- wrong.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10644

AFFECTED FILES
  mercurial/revlogutils/revlogv0.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/revlogutils/revlogv0.py b/mercurial/revlogutils/revlogv0.py
--- a/mercurial/revlogutils/revlogv0.py
+++ b/mercurial/revlogutils/revlogv0.py
@@ -42,6 +42,7 @@ 
 
 class revlogoldindex(list):
     entry_size = INDEX_ENTRY_V0.size
+    null_item = (0, 0, 0, -1, -1, -1, -1, node.nullid)
 
     @property
     def nodemap(self):
@@ -89,7 +90,7 @@ 
 
     def __getitem__(self, i):
         if i == -1:
-            return (0, 0, 0, -1, -1, -1, -1, node.nullid)
+            return self.null_item
         return list.__getitem__(self, i)
 
     def pack_header(self, header):