Patchwork D10579: revlog: introduce a `display_id` property

login
register
mail settings
Submitter phabricator
Date May 3, 2021, 12:01 p.m.
Message ID <differential-rev-PHID-DREV-45qjdkhblblxwzlprsip-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48897/
State Superseded
Headers show

Comments

phabricator - May 3, 2021, 12:01 p.m.
marmoute created this revision.
Herald added a reviewer: indygreg.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We currently using the "index file" to identify a revlog in error output. Since
  we are about to make the "index file" location more volatile, we need something
  better. We move to use the "radix", as it is close to what we currently use.
  
  We could probably do better, as pointed out in the comment, however that would
  be a quite detour from my current goal.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10579

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS




To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -593,6 +593,13 @@ 
         return self.target[0]
 
     @util.propertycache
+    def display_id(self):
+        """The public facing "ID" of the revlog that we use in message"""
+        # Maybe we should build a user facing representation of
+        # revlog.target instead of using `self.radix`
+        return self.radix
+
+    @util.propertycache
     def _compressor(self):
         engine = util.compengines[self._compengine]
         return engine.revlogcompressor(self._compengineopts)