Patchwork D10564: verify: pass a revlog to `_checkrevlog` in `_verifymanifest`

login
register
mail settings
Submitter phabricator
Date May 3, 2021, 11:47 a.m.
Message ID <differential-rev-PHID-DREV-3ddbtscz7lklaqt3sm6g-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48881/
State Superseded
Headers show

Comments

phabricator - May 3, 2021, 11:47 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  Since `manifestrevlog` is not a `revlog`, we are passing strange thing to
  `_checkrevlog`. We fix this to avoid breakage during future change.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10564

AFFECTED FILES
  mercurial/verify.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -326,7 +326,7 @@ 
         if self.refersmf:
             # Do not check manifest if there are only changelog entries with
             # null manifests.
-            self._checkrevlog(mf, label, 0)
+            self._checkrevlog(mf._revlog, label, 0)
         progress = ui.makeprogress(
             _(b'checking'), unit=_(b'manifests'), total=len(mf)
         )