D10439: urlutil: deprecate `getpath`

Submitter	phabricator
Date	April 15, 2021, 8:53 a.m.
Message ID	<differential-rev-PHID-DREV-67msxut6syevnbfephtk-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/48756/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 15 Apr 2021 08:53:12 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "marmoute (Pierre-Yves David)" <phabricator@mercurial-scm.org> Subject: D10439: urlutil: deprecate `getpath` Message-ID: <differential-rev-PHID-DREV-67msxut6syevnbfephtk-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-67msxut6syevnbfephtk Thread-Index: NWFmOTUxYmVmOWI1ZGQzNjllZTRlMDUwNGYw MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "marmoute \(Pierre-Yves David\)" <phabricator+D10439+public+904d2c53da1ecebf@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - April 15, 2021, 8:53 a.m.

marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  There as no remaining user of that function.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10439

AFFECTED FILES
  mercurial/ui.py
  mercurial/utils/urlutil.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/utils/urlutil.py b/mercurial/utils/urlutil.py
--- a/mercurial/utils/urlutil.py
+++ b/mercurial/utils/urlutil.py
@@ -610,6 +610,8 @@ 
         Returns None if ``name`` is not a registered path, a URI, or a local
         path to a repo.
         """
+        msg = b'getpath is deprecated, use `get_*` functions from urlutil'
+        self.deprecwarn(msg, '6.0')
         # Only fall back to default if no path was requested.
         if name is None:
             if not default:
diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -1058,6 +1058,8 @@ 
 
         This method exist as `getpath` need a ui for potential warning message.
         """
+        msg = b'ui.getpath is deprecated, use `get_*` functions from urlutil'
+        self.deprecwarn(msg, '6.0')
         return self.paths.getpath(self, *args, **kwargs)
 
     @property

Patchwork D10439: urlutil: deprecate `getpath`

Comments

Patch