Patchwork D10268: rebase: remove duplicate initialization of a field

login
register
mail settings
Submitter phabricator
Date March 25, 2021, 10:24 p.m.
Message ID <differential-rev-PHID-DREV-w7iva6h6te5i6tnr6dwn-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48583/
State Superseded
Headers show

Comments

phabricator - March 25, 2021, 10:24 p.m.
martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  `obsolete_with_successor_in_destination` is already initialized in the
  constructor.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10268

AFFECTED FILES
  hgext/rebase.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -350,7 +350,6 @@ 
 
     def _handleskippingobsolete(self):
         """Compute structures necessary for skipping obsolete revisions"""
-        self.obsolete_with_successor_in_destination = {}
         if not self.ui.configbool(b'experimental', b'rebaseskipobsolete'):
             return
         obsoleteset = {r for r in self.state if self.repo[r].obsolete()}