Patchwork D10216: configitems: add TODOs blocking the move out of experimental for revlogv2

login
register
mail settings
Submitter phabricator
Date March 15, 2021, 10:25 a.m.
Message ID <differential-rev-PHID-DREV-hxrtaw3bka6x5bxwp6sj-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48531/
State Superseded
Headers show

Comments

phabricator - March 15, 2021, 10:25 a.m.
Alphare created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  These are the todos so far, we probably will have more, but we might as well
  list them while they're fresh in our minds.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10216

AFFECTED FILES
  mercurial/configitems.py

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -1297,6 +1297,14 @@ 
     b'use-persistent-nodemap',
     default=False,
 )
+# TODO needs to grow a docket file to at least store the last offset of the data
+# file when rewriting sidedata.
+# Will also need a way of dealing with garbage data if we allow rewriting
+# *existing* sidedata.
+# Exchange-wise, we will also need to do something more efficient than keeping
+# references to the affected revlogs, especially memory-wise when rewriting
+# sidedata.
+# Also... compress the sidedata? (this should be coming very soon)
 coreconfigitem(
     b'format',
     b'exp-revlogv2.2',