Patchwork D10121: releasenotes: use the right APO to access the 'sections'

login
register
mail settings
Submitter phabricator
Date March 6, 2021, 5:33 a.m.
Message ID <differential-rev-PHID-DREV-tm4fle2ncttbguip3n5z-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48436/
State Superseded
Headers show

Comments

phabricator - March 6, 2021, 5:33 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  Preventing direct access to the underlying dict fix a breakage introduced by the
  refactoring in d3df397e7a59 <https://phab.mercurial-scm.org/rHGd3df397e7a59b416ead210ebcac50579118a5c35>.
  
  This changeset is similar to 271dfcb98544 <https://phab.mercurial-scm.org/rHG271dfcb98544fd05cc7e85cc180dc0cd9e7790cb>, 5272542196cc <https://phab.mercurial-scm.org/rHG5272542196cc6d7ee05f33fe5abd9c006a964650> and f7621fa14b84 <https://phab.mercurial-scm.org/rHGf7621fa14b849ba79e6624beaff03b6a9e7d5592>. The
  breackage of `releasenotes.py` stayed under my radar as the CI did not have
  fuzzywuzzy installed. (Something that is about to be fixed).

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10121

AFFECTED FILES
  hgext/releasenotes.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/hgext/releasenotes.py b/hgext/releasenotes.py
--- a/hgext/releasenotes.py
+++ b/hgext/releasenotes.py
@@ -280,7 +280,7 @@ 
 
     if b'.hgreleasenotes' in ctx:
         read(b'.hgreleasenotes')
-    return p[b'sections']
+    return p.items(b'sections')
 
 
 def checkadmonitions(ui, repo, directives, revs):