Patchwork D10072: test: show internal exception with batchable rpcs over ssh

login
register
mail settings
Submitter phabricator
Date Feb. 25, 2021, 3:37 p.m.
Message ID <differential-rev-PHID-DREV-irctuupycxgx2viqnqy4-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48387/
State Superseded
Headers show

Comments

phabricator - Feb. 25, 2021, 3:37 p.m.
valentin.gatienbaron created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10072

AFFECTED FILES
  tests/test-ssh-batch.t

CHANGE DETAILS




To: valentin.gatienbaron, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-ssh-batch.t b/tests/test-ssh-batch.t
new file mode 100644
--- /dev/null
+++ b/tests/test-ssh-batch.t
@@ -0,0 +1,13 @@ 
+  $ hg init a
+  $ cd a
+  $ touch a; hg commit -qAm_
+  $ hg bookmark $(for i in $($TESTDIR/seq.py 0 20); do echo b$i; done)
+  $ hg clone . ../b -q
+  $ cd ../b
+
+Checking that when lookup multiple bookmarks in one go, if one of them
+fails (thus causing the sshpeer to be stopped), the errors from the
+further lookups don't result in tracebacks.
+
+  $ hg pull -r b0 -r nosuchbookmark $(for i in $($TESTDIR/seq.py 1 20); do echo -r b$i; done) -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/$(pwd)/../a |& tail -n 1
+  ValueError: I/O operation on closed file