Patchwork D9975: tweak-default: no longer enable the experimental return code

login
register
mail settings
Submitter phabricator
Date Feb. 10, 2021, 7:01 p.m.
Message ID <differential-rev-PHID-DREV-zo4um2yldvh5pineian2-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48290/
State Superseded
Headers show

Comments

phabricator - Feb. 10, 2021, 7:01 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The change is quite new and undocumented (since it is experimental) so it seems
  premature to make it available in tweak default. In addition, I am not sure the
  new return code are frozen yet (eg: some of the initial feedback have not been
  incorporated). Before the release I doubled check (probably with Martin) that
  they were not enabled by default and got replied that they were only enabled in
  the tests. Have I been aware that they have been also enabled in tweak default I
  would I have lobbied to delay that.
  
  I discovered they were in tweak default from users feedback. They found it an
  unpleasant and unexpected surprise of 5.7.
  
  So I suggest we no enable enable this experimental feature for Mercurial 5.7 and
  revisit this later, when the feature will be more mature.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D9975

AFFECTED FILES
  mercurial/ui.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -60,8 +60,6 @@ 
 # The config knobs that will be altered (if unset) by ui.tweakdefaults.
 tweakrc = b"""
 [ui]
-# Gives detailed exit codes for input/user errors, config errors, etc.
-detailed-exit-code = True
 # The rollback command is dangerous. As a rule, don't use it.
 rollback = False
 # Make `hg status` report copy information