Patchwork D9974: cmdutil: add a missing byte prefix to string introduce in 976b26bdd0d8

login
register
mail settings
Submitter phabricator
Date Feb. 9, 2021, 11:12 p.m.
Message ID <differential-rev-PHID-DREV-qszyq7e67oseusbzk6dm-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48289/
State Superseded
Headers show

Comments

phabricator - Feb. 9, 2021, 11:12 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The change is missing a the `b'foo'` prefix to make it a bytestring. This lead
  to a traceback in some third party extension. It is unclear to me why the
  Mercurial test pass without it.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D9974

AFFECTED FILES
  mercurial/cmdutil.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -3145,7 +3145,7 @@ 
         # avoid reporting something like "committed new head" when
         # recommitting old changesets, and issue a helpful warning
         # for most instances
-        repo.ui.warn(_("warning: commit already existed in the repository!\n"))
+        repo.ui.warn(_(b"warning: commit already existed in the repository!\n"))
     elif (
         not opts.get(b'amend')
         and bheads