Patchwork D9923: config: use the right API to access git-submodule

login
register
mail settings
Submitter phabricator
Date Jan. 30, 2021, 1:39 a.m.
Message ID <differential-rev-PHID-DREV-rtouwh6o6dfpf74j3hly-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48234/
State Superseded
Headers show

Comments

phabricator - Jan. 30, 2021, 1:39 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9923

AFFECTED FILES
  hgext/convert/git.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/hgext/convert/git.py b/hgext/convert/git.py
--- a/hgext/convert/git.py
+++ b/hgext/convert/git.py
@@ -247,7 +247,8 @@ 
             b'\n'.join(line.strip() for line in content.split(b'\n')),
         )
         for sec in c.sections():
-            s = c[sec]
+            # turn the config object into a real dict
+            s = dict(c.items(sec))
             if b'url' in s and b'path' in s:
                 self.submodules.append(submodule(s[b'path'], b'', s[b'url']))