Patchwork D9898: narrow: delete a stale TODO about not sending groups the client already has

login
register
mail settings
Submitter phabricator
Date Jan. 28, 2021, 6:19 a.m.
Message ID <differential-rev-PHID-DREV-33opjpr5sms7wuecybj5-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/48209/
State Superseded
Headers show

Comments

phabricator - Jan. 28, 2021, 6:19 a.m.
martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  2c5835b4246b <https://phab.mercurial-scm.org/rHG2c5835b4246be6ea42e4b4c7b42dc23e379e2c23> changed the changegroup generation to not send
  treemanifests for directories the client had before widening. As that
  commit mentions, we had already stopped before that commit to send the
  changelog and filelogs for files the client already had.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9898

AFFECTED FILES
  mercurial/bundle2.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/bundle2.py b/mercurial/bundle2.py
--- a/mercurial/bundle2.py
+++ b/mercurial/bundle2.py
@@ -2536,8 +2536,6 @@ 
     for r in repo.revs(b"::%ln", common):
         commonnodes.add(cl.node(r))
     if commonnodes:
-        # XXX: we should only send the filelogs (and treemanifest). user
-        # already has the changelog and manifest
         packer = changegroup.getbundler(
             cgversion,
             repo,