Patchwork revset-benchmark: add max(::(tip~20) - obsolete())

login
register
mail settings
Submitter Pierre-Yves David
Date May 19, 2014, 9:39 p.m.
Message ID <d96ab4084652604af3e6.1400535594@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/4820/
State Accepted
Headers show

Comments

Pierre-Yves David - May 19, 2014, 9:39 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1400535559 25200
#      Mon May 19 14:39:19 2014 -0700
# Node ID d96ab4084652604af3e668706660c496bb15822f
# Parent  63c3014d89ccc998da6fca896304c0f098da6eb6
revset-benchmark: add max(::(tip~20) - obsolete())

This revset is used in evolve. The new revset lazyness should make it all faster
but in practice it is significantly slower.

Below is a timing for this entry on my Mercurial repo.

2.9.2) ! wall 0.034598 comb 0.040000 user 0.040000 sys 0.000000 (best of 100)
3.0+@) ! wall 0.062268 comb 0.060000 user 0.060000 sys 0.000000 (best of 100)

The ~20 have been taken arbitrary.
Augie Fackler - May 26, 2014, 4:24 p.m.
On Mon, May 19, 2014 at 02:39:54PM -0700, pierre-yves.david@ens-lyon.org wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1400535559 25200
> #      Mon May 19 14:39:19 2014 -0700
> # Node ID d96ab4084652604af3e668706660c496bb15822f
> # Parent  63c3014d89ccc998da6fca896304c0f098da6eb6
> revset-benchmark: add max(::(tip~20) - obsolete())

queued, thanks.

>
> This revset is used in evolve. The new revset lazyness should make it all faster
> but in practice it is significantly slower.
>
> Below is a timing for this entry on my Mercurial repo.
>
> 2.9.2) ! wall 0.034598 comb 0.040000 user 0.040000 sys 0.000000 (best of 100)
> 3.0+@) ! wall 0.062268 comb 0.060000 user 0.060000 sys 0.000000 (best of 100)
>
> The ~20 have been taken arbitrary.
>
> diff --git a/contrib/revsetbenchmarks.txt b/contrib/revsetbenchmarks.txt
> --- a/contrib/revsetbenchmarks.txt
> +++ b/contrib/revsetbenchmarks.txt
> @@ -18,5 +18,6 @@ roots((tip~100::) - (tip~100::tip))
>  ::p1(p1(tip))::
>  public()
>  :10000 and public()
>  draft()
>  :10000 and draft()
> +max(::(tip~20) - obsolete())
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/contrib/revsetbenchmarks.txt b/contrib/revsetbenchmarks.txt
--- a/contrib/revsetbenchmarks.txt
+++ b/contrib/revsetbenchmarks.txt
@@ -18,5 +18,6 @@  roots((tip~100::) - (tip~100::tip))
 ::p1(p1(tip))::
 public()
 :10000 and public()
 draft()
 :10000 and draft()
+max(::(tip~20) - obsolete())