Patchwork [05,of,12] workingctx: add note about super._prestatus calling manifest

login
register
mail settings
Submitter Sean Farley
Date May 19, 2014, 8:32 p.m.
Message ID <4518af73d5c902e6e43c.1400531532@laptop.local>
Download mbox | patch
Permalink /patch/4807/
State Accepted
Commit e5deefcaa12ba22393702f4573b1bfd960e44483
Headers show

Comments

Sean Farley - May 19, 2014, 8:32 p.m.
# HG changeset patch
# User Sean Farley <sean.michael.farley@gmail.com>
# Date 1398287202 18000
#      Wed Apr 23 16:06:42 2014 -0500
# Node ID 4518af73d5c902e6e43ce342849a9240852d98d4
# Parent  fc8654d37dd78bc8f79554f06f0b3f141fc9d8b2
workingctx: add note about super._prestatus calling manifest

Patch

diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -1308,10 +1308,13 @@  class workingctx(committablectx):
         """override the parent hook with a dirstate query
 
         We use this prestatus hook to populate the status with information from
         the dirstate.
         """
+        # doesn't need to call super; if that changes, be aware that super
+        # calls self.manifest which would slow down the common case of calling
+        # status against a workingctx's parent
         return self._dirstatestatus(match, listignored, listclean, listunknown)
 
     def _poststatus(self, other, s, match, listignored, listclean, listunknown):
         """override the parent hook with a filter for suspect symlinks