Patchwork [3,of,3] dispatch: remove stale comment about fdopen()-ed stdio

login
register
mail settings
Submitter Yuya Nishihara
Date Dec. 18, 2020, 12:56 p.m.
Message ID <567d926ac2b6abfdcd03.1608296185@lemosa>
Download mbox | patch
Permalink /patch/47934/
State New
Headers show

Comments

Yuya Nishihara - Dec. 18, 2020, 12:56 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1608291311 -32400
#      Fri Dec 18 20:35:11 2020 +0900
# Node ID 567d926ac2b6abfdcd0367540921dfccf8709c71
# Parent  bd4e513e64c974c38963b60fc14d4bbce6d574fe
dispatch: remove stale comment about fdopen()-ed stdio

On Python 3, stdout is just wrapped by LineBufferedWrapper.

Patch

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -217,9 +217,7 @@  if pycompat.ispy3:
             except IOError:
                 pass
             # Otherwise mark it as closed to silence "Exception ignored in"
-            # message emitted by the interpreter finalizer. Be careful to
-            # not close procutil.stdout, which may be a fdopen-ed file object
-            # and its close() actually closes the underlying file descriptor.
+            # message emitted by the interpreter finalizer.
             try:
                 fp.close()
             except IOError: