D9605: hook: set `HGPLAIN=1` for external hooks

Submitter	phabricator
Date	Dec. 15, 2020, 12:37 a.m.
Message ID	<differential-rev-PHID-DREV-27pcbrfmev44wq5eg7kw-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/47902/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Tue, 15 Dec 2020 00:37:53 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "mharbison72 (Matt Harbison)" <phabricator@mercurial-scm.org> Subject: D9605: hook: set `HGPLAIN=1` for external hooks Message-ID: <differential-rev-PHID-DREV-27pcbrfmev44wq5eg7kw-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-27pcbrfmev44wq5eg7kw Thread-Index: Nzc1NDMwZGY0MzI1MDU3NjkyMWRlNjRkNDc2 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "mharbison72 \(Matt Harbison\)" <phabricator+D9605+public+3805e2c173475c3c@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Dec. 15, 2020, 12:37 a.m.

mharbison72 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  External hooks will probably turn around and run hg commands, so this seems like
  a reasonable convenience for people who miss it in the documentation.
  
  There are no test changes because `printenv.py` filters out anything without a
  "HG_" prefix.  It wouldn't be a useful test anyway, because this is already
  inherited from the test environment.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9605

AFFECTED FILES
  mercurial/hook.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/hook.py b/mercurial/hook.py
--- a/mercurial/hook.py
+++ b/mercurial/hook.py
@@ -157,6 +157,7 @@ 
             env[b'HG_PENDING'] = repo.root
     env[b'HG_HOOKTYPE'] = htype
     env[b'HG_HOOKNAME'] = name
+    env[b'HGPLAIN'] = b'1'
 
     for k, v in pycompat.iteritems(args):
         # transaction changes can accumulate MBs of data, so skip it

Patchwork D9605: hook: set `HGPLAIN=1` for external hooks

Comments

Patch