Patchwork D9544: extensions: avoid including `__index__` in the disabled extension list

login
register
mail settings
Submitter phabricator
Date Dec. 8, 2020, 4:04 p.m.
Message ID <differential-rev-PHID-DREV-zwxyfztour5xobrlrqca-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47840/
State Superseded
Headers show

Comments

phabricator - Dec. 8, 2020, 4:04 p.m.
mharbison72 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This generated module contains a dictionary of all bundled extension names and
  their help for builds that cannot enumerate extensions in the filesystem.
  
  The disabled list gets displayed in `hg help extensions`, and is also used by
  `setup.py` to populate `__index__.py` when building.  I haven't seen it sneak
  into either py2exe or PyOxidizer builds, but it does show up when running tests
  locally after having created an installer.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9544

AFFECTED FILES
  mercurial/extensions.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/extensions.py b/mercurial/extensions.py
--- a/mercurial/extensions.py
+++ b/mercurial/extensions.py
@@ -810,7 +810,7 @@ 
     exts = {}
     for name, path in pycompat.iteritems(paths):
         doc = _disabledhelp(path)
-        if doc:
+        if doc and name != b'__index__':
             exts[name] = doc.splitlines()[0]
 
     return exts