Patchwork D9473: upgrade: capitalize the `deficiency` constant

login
register
mail settings
Submitter phabricator
Date Dec. 1, 2020, 9:54 a.m.
Message ID <differential-rev-PHID-DREV-fyvltkzlrn6cw5qinpht-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47751/
State Superseded
Headers show

Comments

phabricator - Dec. 1, 2020, 9:54 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  I am reworking this code and moving to the current naming scheme help
  readability.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9473

AFFECTED FILES
  mercurial/upgrade.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/upgrade.py b/mercurial/upgrade.py
--- a/mercurial/upgrade.py
+++ b/mercurial/upgrade.py
@@ -151,7 +151,7 @@ 
     return set()
 
 
-deficiency = b'deficiency'
+DEFICIENCY = b'deficiency'
 optimisation = b'optimization'
 
 
@@ -165,13 +165,13 @@ 
        will be mapped to an action later in the upgrade process.
 
     type
-       Either ``deficiency`` or ``optimisation``. A deficiency is an obvious
+       Either ``DEFICIENCY`` or ``optimisation``. A deficiency is an obvious
        problem. An optimization is an action (sometimes optional) that
        can be taken to further improve the state of the repository.
 
     description
        Message intended for humans explaining the improvement in more detail,
-       including the implications of it. For ``deficiency`` types, should be
+       including the implications of it. For ``DEFICIENCY`` types, should be
        worded in the present tense. For ``optimisation`` types, should be
        worded in the future tense.
 
@@ -210,7 +210,7 @@ 
 class formatvariant(improvement):
     """an improvement subclass dedicated to repository format"""
 
-    type = deficiency
+    type = DEFICIENCY
     ### The following attributes should be defined for each class:
 
     # machine-readable string uniquely identifying this improvement. it will be
@@ -218,7 +218,7 @@ 
     name = None
 
     # message intended for humans explaining the improvement in more detail,
-    # including the implications of it ``deficiency`` types, should be worded
+    # including the implications of it ``DEFICIENCY`` types, should be worded
     # in the present tense.
     description = None