Patchwork D9379: errors: consistently don't use trailing "!" in "not found in manifest" message

login
register
mail settings
Submitter phabricator
Date Nov. 23, 2020, 11:32 p.m.
Message ID <differential-rev-PHID-DREV-46mdgokx4adyasx4xfkf-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47659/
State Superseded
Headers show

Comments

phabricator - Nov. 23, 2020, 11:32 p.m.
martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We already had some places with the same message without the trailing
  "!".

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9379

AFFECTED FILES
  mercurial/commands.py
  tests/test-parents.t
  tests/test-remotefilelog-prefetch.t

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-remotefilelog-prefetch.t b/tests/test-remotefilelog-prefetch.t
--- a/tests/test-remotefilelog-prefetch.t
+++ b/tests/test-remotefilelog-prefetch.t
@@ -239,7 +239,7 @@ 
 .. hopefully this flakyness is not hiding any actual bug.
   $ hg revert -a -r 1 || true
   ? files fetched over 1 fetches - (? misses, 0.00% hit ratio) over * (glob)
-  abort: z2@109c3a557a73: not found in manifest! (?)
+  abort: z2@109c3a557a73: not found in manifest (?)
   $ find $CACHEDIR -type f | sort
   $TESTTMP/hgcache/master/11/f6ad8ec52a2984abaafd7c3b516503785c2072/ef95c5376f34698742fe34f315fd82136f8f68c0
   $TESTTMP/hgcache/master/39/5df8f7c51f007019cb30201c49e884b46b92fa/69a1b67522704ec122181c0890bd16e9d3e7516a
diff --git a/tests/test-parents.t b/tests/test-parents.t
--- a/tests/test-parents.t
+++ b/tests/test-parents.t
@@ -53,7 +53,7 @@ 
   
 
   $ hg parents -r 3 c
-  abort: 'c' not found in manifest!
+  abort: 'c' not found in manifest
   [10]
 
   $ hg parents -r 2
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -4999,7 +4999,7 @@ 
             except error.LookupError:
                 pass
         if not filenodes:
-            raise error.InputError(_(b"'%s' not found in manifest!") % file_)
+            raise error.InputError(_(b"'%s' not found in manifest") % file_)
         p = []
         for fn in filenodes:
             fctx = repo.filectx(file_, fileid=fn)