Patchwork D9374: bisect: add a `--rev` flag

login
register
mail settings
Submitter phabricator
Date Nov. 23, 2020, 5:19 p.m.
Message ID <differential-rev-PHID-DREV-zeze5mtiuy7eyilgbbdb-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47653/
State New
Headers show

Comments

phabricator - Nov. 23, 2020, 5:19 p.m.
SimonSapin created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This is the same as the positional argument, and can be passed more than once.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9374

AFFECTED FILES
  mercurial/commands.py
  tests/test-bisect.t
  tests/test-completion.t

CHANGE DETAILS




To: SimonSapin, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-completion.t b/tests/test-completion.t
--- a/tests/test-completion.t
+++ b/tests/test-completion.t
@@ -251,7 +251,7 @@ 
   annotate: rev, follow, no-follow, text, user, file, date, number, changeset, line-number, skip, ignore-all-space, ignore-space-change, ignore-blank-lines, ignore-space-at-eol, include, exclude, template
   archive: no-decode, prefix, rev, type, subrepos, include, exclude
   backout: merge, commit, no-commit, parent, rev, edit, tool, include, exclude, message, logfile, date, user
-  bisect: reset, good, bad, skip, extend, command, noupdate
+  bisect: reset, good, bad, skip, rev, extend, command, noupdate
   bookmarks: force, rev, delete, rename, inactive, list, template
   branch: force, clean, rev
   branches: active, closed, rev, template
diff --git a/tests/test-bisect.t b/tests/test-bisect.t
--- a/tests/test-bisect.t
+++ b/tests/test-bisect.t
@@ -232,8 +232,8 @@ 
 
   $ hg bisect -r
   $ hg bisect -b "0::3"
-  $ hg bisect -s "13::16"
-  $ hg bisect -g "26::tip"
+  $ hg bisect -s --rev "13::16"
+  $ hg bisect -g --rev "26::28" --rev "29" "30::tip"
   Testing changeset 12:1941b52820a5 (23 changesets remaining, ~4 tests)
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cat .hg/bisect.state
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -891,6 +891,7 @@ 
         (b'g', b'good', False, _(b'mark changeset good')),
         (b'b', b'bad', False, _(b'mark changeset bad')),
         (b's', b'skip', False, _(b'skip testing changeset')),
+        (b'', b'rev', [], _(b'select the changesets to mark')),
         (b'e', b'extend', False, _(b'extend the bisect range')),
         (
             b'c',
@@ -909,6 +910,7 @@ 
     repo,
     positional_1=None,
     positional_2=None,
+    rev=None,
     command=None,
     reset=None,
     good=None,
@@ -998,7 +1000,6 @@ 
 
     Returns 0 on success.
     """
-    rev = []
     # backward compatibility
     if positional_1 in (b"good", b"bad", b"reset", b"init"):
         ui.warn(_(b"(use of 'hg bisect <cmd>' is deprecated)\n"))