From patchwork Sun Nov 22 20:08:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D9366: helptext: fix sentence in extensions documentation From: phabricator X-Patchwork-Id: 47645 Message-Id: To: Phabricator Cc: mercurial-devel@mercurial-scm.org Date: Sun, 22 Nov 2020 20:08:34 +0000 mharbison72 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9366 AFFECTED FILES mercurial/helptext/internals/extensions.txt CHANGE DETAILS To: mharbison72, #hg-reviewers Cc: mercurial-patches, mercurial-devel diff --git a/mercurial/helptext/internals/extensions.txt b/mercurial/helptext/internals/extensions.txt --- a/mercurial/helptext/internals/extensions.txt +++ b/mercurial/helptext/internals/extensions.txt @@ -175,7 +175,7 @@ Be aware that ``uisetup`` in NOT the function to configure a ``ui`` instance. It's called only once per process, not per ``ui`` instance. Also, any changes -to the ``ui`` may be discarded because the ``ui`` here temporarily loaded +to the ``ui`` may be discarded because the ``ui`` here is a temporarily loaded local configuration. So, it's generally wrong to do `ui.setconfig()` in these callbacks. Notable exception is setting ``pre/post-`` hooks and extending ``ui.__class__``.