D9308: errors: raise InputError in fancyopts

Submitter	phabricator
Date	Nov. 12, 2020, 4:39 p.m.
Message ID	<differential-rev-PHID-DREV-hanupiad4a6v2sb2h2ro-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/47583/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 12 Nov 2020 16:39:37 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "martinvonz (Martin von Zweigbergk)" <phabricator@mercurial-scm.org> Subject: D9308: errors: raise InputError in fancyopts Message-ID: <differential-rev-PHID-DREV-hanupiad4a6v2sb2h2ro-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-hanupiad4a6v2sb2h2ro Thread-Index: MjFiMDJhMmIxMjM0ZjMwYWE0NmUyODg4OGFh MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "martinvonz \(Martin von Zweigbergk\)" <phabricator+D9308+public+7f09f5b2b4478a13@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Nov. 12, 2020, 4:39 p.m.

martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  If a value of wrong type is passed to a command line flag, that's
  cleary an InputError.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9308

AFFECTED FILES
  mercurial/fancyopts.py
  tests/test-import.t

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-import.t b/tests/test-import.t
--- a/tests/test-import.t
+++ b/tests/test-import.t
@@ -1036,7 +1036,7 @@ 
   adding a
   $ hg import -p foo
   abort: invalid value 'foo' for option -p, expected int
-  [255]
+  [10]
   $ hg import -p0 - << EOF
   > foobar
   > --- a	Sat Apr 12 22:43:58 2008 -0400
diff --git a/mercurial/fancyopts.py b/mercurial/fancyopts.py
--- a/mercurial/fancyopts.py
+++ b/mercurial/fancyopts.py
@@ -380,7 +380,7 @@ 
         else:
 
             def abort(s):
-                raise error.Abort(
+                raise error.InputError(
                     _(b'invalid value %r for option %s, %s')
                     % (pycompat.maybebytestr(val), opt, s)
                 )

Patchwork D9308: errors: raise InputError in fancyopts

Comments

Patch