Patchwork [1,of,3] upgrade: improve documentation of matchrevlog()

login
register
mail settings
Submitter Pulkit Goyal
Date Oct. 10, 2020, 8:47 a.m.
Message ID <3fb44ab16f68b2f76a75.1602319642@workspace>
Download mbox | patch
Permalink /patch/47433/
State Accepted
Headers show

Comments

Pulkit Goyal - Oct. 10, 2020, 8:47 a.m.
# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1602158391 -19800
#      Thu Oct 08 17:29:51 2020 +0530
# Node ID 3fb44ab16f68b2f76a752e873cce80d45fec442f
# Parent  64a9423450efb39d7f1bc5b6b2cca1efafb1870e
# EXP-Topic sidedata-upgrade
upgrade: improve documentation of matchrevlog()

It was not clear what selected for cloning meant. I updated with an extra line
of description.
Yuya Nishihara - Oct. 11, 2020, 2:32 a.m.
On Sat, 10 Oct 2020 14:17:22 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1602158391 -19800
> #      Thu Oct 08 17:29:51 2020 +0530
> # Node ID 3fb44ab16f68b2f76a752e873cce80d45fec442f
> # Parent  64a9423450efb39d7f1bc5b6b2cca1efafb1870e
> # EXP-Topic sidedata-upgrade
> upgrade: improve documentation of matchrevlog()

Queued this, thanks.

Patch

diff --git a/mercurial/upgrade.py b/mercurial/upgrade.py
--- a/mercurial/upgrade.py
+++ b/mercurial/upgrade.py
@@ -743,7 +743,10 @@  def getsidedatacompanion(srcrepo, dstrep
 
 
 def matchrevlog(revlogfilter, entry):
-    """check is a revlog is selected for cloning
+    """check if a revlog is selected for cloning.
+
+    In other words, are there any updates which needs to be done on revlog
+    or it can be blindly copied
 
     The store entry is checked against the passed filter"""
     if entry.endswith(b'00changelog.i'):