Patchwork [1,of,3,V2] revsetbenchmark: add `author(mpm) or author(lmoscovicz)` to the canonical list

login
register
mail settings
Submitter Pierre-Yves David
Date May 13, 2014, 8:19 a.m.
Message ID <d8a52ce003ac21569dae.1399969155@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/4735/
State Accepted
Commit 883e268cb860c0ea2eb0faa94114e11c3a4a3893
Headers show

Comments

Pierre-Yves David - May 13, 2014, 8:19 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1398908420 25200
#      Wed Apr 30 18:40:20 2014 -0700
# Node ID d8a52ce003ac21569dae2023ecc648e7769bdb54
# Parent  007d276f8c9461384be3e7b75ee0aa69b33125fb
revsetbenchmark: add `author(mpm) or author(lmoscovicz)` to the canonical list

This matters as `author(mpm)` have a lot of matches evenly split in the repo,
while `author(lmoscoviz)` have less match (and later). This changes the execution
path of the "or" operator a lot.
Augie Fackler - May 14, 2014, 1:02 a.m.
Queued this one, holding off on the other two until you confirm/refute my theory about __file__ in patch 2.

On May 13, 2014, at 4:19 AM, pierre-yves.david@ens-lyon.org wrote:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1398908420 25200
> #      Wed Apr 30 18:40:20 2014 -0700
> # Node ID d8a52ce003ac21569dae2023ecc648e7769bdb54
> # Parent  007d276f8c9461384be3e7b75ee0aa69b33125fb
> revsetbenchmark: add `author(mpm) or author(lmoscovicz)` to the canonical list
> 
> This matters as `author(mpm)` have a lot of matches evenly split in the repo,
> while `author(lmoscoviz)` have less match (and later). This changes the execution
> path of the "or" operator a lot.
> 
> diff --git a/contrib/revsetbenchmarks.txt b/contrib/revsetbenchmarks.txt
> --- a/contrib/revsetbenchmarks.txt
> +++ b/contrib/revsetbenchmarks.txt
> @@ -6,10 +6,11 @@ draft() and ::tip
> 0::tip
> roots(0::tip)
> author(lmoscovicz)
> author(mpm)
> author(lmoscovicz) or author(mpm)
> +author(mpm) or author(lmoscovicz)
> tip:0
> max(tip:0)
> min(0:tip)
> 0::
> min(0::)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/contrib/revsetbenchmarks.txt b/contrib/revsetbenchmarks.txt
--- a/contrib/revsetbenchmarks.txt
+++ b/contrib/revsetbenchmarks.txt
@@ -6,10 +6,11 @@  draft() and ::tip
 0::tip
 roots(0::tip)
 author(lmoscovicz)
 author(mpm)
 author(lmoscovicz) or author(mpm)
+author(mpm) or author(lmoscovicz)
 tip:0
 max(tip:0)
 min(0:tip)
 0::
 min(0::)