Patchwork D9113: copies: rename some function to the new naming scheme

login
register
mail settings
Submitter phabricator
Date Sept. 28, 2020, 4:32 p.m.
Message ID <differential-rev-PHID-DREV-vjahtghe54b2ireo47r3-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47328/
State Superseded
Headers show

Comments

phabricator - Sept. 28, 2020, 4:32 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We are about to introduce more function and more variants, it seems better to
  align everything on the new scheme, allowing `_` for clarify. We do this aligned
  in a dedicated changeset to make the next changesets simpler.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9113

AFFECTED FILES
  mercurial/copies.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/copies.py b/mercurial/copies.py
--- a/mercurial/copies.py
+++ b/mercurial/copies.py
@@ -172,7 +172,7 @@ 
     return cm
 
 
-def _revinfogetter(repo):
+def _revinfo_getter(repo):
     """return a function that return multiple data given a <rev>"i
 
     * p1: revision number of first parent
@@ -278,7 +278,7 @@ 
 
     repo = a.repo().unfiltered()
     children = {}
-    revinfo = _revinfogetter(repo)
+    revinfo = _revinfo_getter(repo)
 
     cl = repo.changelog
     isancestor = cl.isancestorrev  # XXX we should had chaching to this.
@@ -309,12 +309,12 @@ 
     iterrevs.update(roots)
     iterrevs.remove(b.rev())
     revs = sorted(iterrevs)
-    return _combinechangesetcopies(
+    return _combine_changeset_copies(
         revs, children, b.rev(), revinfo, match, isancestor
     )
 
 
-def _combinechangesetcopies(
+def _combine_changeset_copies(
     revs, children, targetrev, revinfo, match, isancestor
 ):
     """combine the copies information for each item of iterrevs