Patchwork D9091: changing-files: drop the now useless changelogrevision argument

login
register
mail settings
Submitter phabricator
Date Sept. 26, 2020, 12:10 p.m.
Message ID <differential-rev-PHID-DREV-2uhjgwy6ffbh5thimfaf-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47292/
State Superseded
Headers show

Comments

phabricator - Sept. 26, 2020, 12:10 p.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  Since all filename are now included in the sidedata block, we no longer need to decode the `files` from the revision.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9091

AFFECTED FILES
  mercurial/changelog.py
  mercurial/metadata.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/metadata.py b/mercurial/metadata.py
--- a/mercurial/metadata.py
+++ b/mercurial/metadata.py
@@ -425,7 +425,7 @@ 
     return {sidedatamod.SD_FILES: b''.join(chunks)}
 
 
-def decode_files_sidedata(changelogrevision, sidedata):
+def decode_files_sidedata(sidedata):
     md = ChangingFiles()
     raw = sidedata.get(sidedatamod.SD_FILES)
 
diff --git a/mercurial/changelog.py b/mercurial/changelog.py
--- a/mercurial/changelog.py
+++ b/mercurial/changelog.py
@@ -305,7 +305,7 @@ 
         if self._changes is not None:
             return self._changes
         if self._cpsd:
-            changes = metadata.decode_files_sidedata(self, self._sidedata)
+            changes = metadata.decode_files_sidedata(self._sidedata)
         else:
             changes = metadata.ChangingFiles(
                 touched=self.files or (),