Patchwork share: do not write working-copy requirements twice

login
register
mail settings
Submitter Yuya Nishihara
Date Sept. 18, 2020, 11:49 a.m.
Message ID <a8843eda9a35e4880dda.1600429743@mimosa>
Download mbox | patch
Permalink /patch/47219/
State Accepted
Headers show

Comments

Yuya Nishihara - Sept. 18, 2020, 11:49 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1600427992 -32400
#      Fri Sep 18 20:19:52 2020 +0900
# Node ID a8843eda9a35e4880dda58f59be42823e1078308
# Parent  c7fe0dfb53122bb72ff7e1fab75f2eec28b1883c
share: do not write working-copy requirements twice

Follows up d252f51ab032. Maybe it is a copy-paste error.
Pulkit Goyal - Sept. 18, 2020, 12:09 p.m.
On Fri, Sep 18, 2020 at 5:36 PM Yuya Nishihara <yuya@tcha.org> wrote:
>
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1600427992 -32400
> #      Fri Sep 18 20:19:52 2020 +0900
> # Node ID a8843eda9a35e4880dda58f59be42823e1078308
> # Parent  c7fe0dfb53122bb72ff7e1fab75f2eec28b1883c
> share: do not write working-copy requirements twice
>
> Follows up d252f51ab032. Maybe it is a copy-paste error.

Queued this. Many thanks!

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -3537,7 +3537,6 @@  def createrepository(ui, path, createopt
     # For new shared repository, we don't need to write the store
     # requirements as they are already present in store requires
     if storereq and b'sharedrepo' not in createopts:
-        scmutil.writerequires(hgvfs, wcreq)
         storevfs = vfsmod.vfs(hgvfs.join(b'store'), cacheaudited=True)
         scmutil.writerequires(storevfs, storereq)