Patchwork [2,of,6] log: remove unused argument from _makerevset()

login
register
mail settings
Submitter Yuya Nishihara
Date Sept. 18, 2020, 11:06 a.m.
Message ID <13e908cbcada06903f27.1600427182@mimosa>
Download mbox | patch
Permalink /patch/47209/
State Accepted
Headers show

Comments

Yuya Nishihara - Sept. 18, 2020, 11:06 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1599895141 -32400
#      Sat Sep 12 16:19:01 2020 +0900
# Node ID 13e908cbcada06903f27803def8ca3fa919e3310
# Parent  5029cecce6ad76a194ad5478ac3fda614f3d32d6
log: remove unused argument from _makerevset()

I want to make getrevs() reusable for other commands, but the dependency graph
of this getrevs() function is a mess. Let's minimize it first.

Patch

diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -800,7 +800,7 @@  def _makenofollowfilematcher(repo, pats,
 }
 
 
-def _makerevset(repo, match, pats, slowpath, opts):
+def _makerevset(repo, pats, slowpath, opts):
     """Return a revset string built from log options and file patterns"""
     opts = dict(opts)
     # follow or not follow?
@@ -896,7 +896,7 @@  def getrevs(repo, pats, opts):
         def filematcher(ctx):
             return match
 
-    expr = _makerevset(repo, match, pats, slowpath, opts)
+    expr = _makerevset(repo, pats, slowpath, opts)
     if opts.get(b'graph'):
         if repo.ui.configbool(b'experimental', b'log.topo'):
             if not revs.istopo():
diff --git a/tests/printrevset.py b/tests/printrevset.py
--- a/tests/printrevset.py
+++ b/tests/printrevset.py
@@ -16,7 +16,7 @@  def logrevset(repo, pats, opts):
     if not revs:
         return None
     match, pats, slowpath = logcmdutil._makematcher(repo, revs, pats, opts)
-    return logcmdutil._makerevset(repo, match, pats, slowpath, opts)
+    return logcmdutil._makerevset(repo, pats, slowpath, opts)
 
 
 def uisetup(ui):