Patchwork [1,of,6] log: remove stale comment about order of user revset

login
register
mail settings
Submitter Yuya Nishihara
Date Sept. 18, 2020, 11:06 a.m.
Message ID <5029cecce6ad76a194ad.1600427181@mimosa>
Download mbox | patch
Permalink /patch/47207/
State Accepted
Headers show

Comments

Yuya Nishihara - Sept. 18, 2020, 11:06 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1599894670 -32400
#      Sat Sep 12 16:11:10 2020 +0900
# Node ID 5029cecce6ad76a194ad5478ac3fda614f3d32d6
# Parent  c7fe0dfb53122bb72ff7e1fab75f2eec28b1883c
log: remove stale comment about order of user revset

_makerevset() no longer depends on the computed revs since ea3320015d54 "log:
remove dead code to follow descendants if ascending revisions specified."
Pulkit Goyal - Sept. 26, 2020, 10:21 a.m.
On Fri, Sep 18, 2020 at 4:43 PM Yuya Nishihara <yuya@tcha.org> wrote:
>
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1599894670 -32400
> #      Sat Sep 12 16:11:10 2020 +0900
> # Node ID 5029cecce6ad76a194ad5478ac3fda614f3d32d6
> # Parent  c7fe0dfb53122bb72ff7e1fab75f2eec28b1883c
> log: remove stale comment about order of user revset
>
> _makerevset() no longer depends on the computed revs since ea3320015d54 "log:
> remove dead code to follow descendants if ascending revisions specified."

Queued the series, many thanks!

Patch

diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -898,14 +898,13 @@  def getrevs(repo, pats, opts):
 
     expr = _makerevset(repo, match, pats, slowpath, opts)
     if opts.get(b'graph'):
-        # User-specified revs might be unsorted, but don't sort before
-        # _makerevset because it might depend on the order of revs
         if repo.ui.configbool(b'experimental', b'log.topo'):
             if not revs.istopo():
                 revs = dagop.toposort(revs, repo.changelog.parentrevs)
                 # TODO: try to iterate the set lazily
                 revs = revset.baseset(list(revs), istopo=True)
         elif not (revs.isdescending() or revs.istopo()):
+            # User-specified revs might be unsorted
             revs.sort(reverse=True)
     if expr:
         matcher = revset.match(None, expr)