Patchwork D9010: hg-core: add `Changlog` a specialized `Revlog`

login
register
mail settings
Submitter phabricator
Date Sept. 11, 2020, 7:53 a.m.
Message ID <differential-rev-PHID-DREV-dqquvfevevfyppx3c4sh-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47138/
State Superseded
Headers show

Comments

phabricator - Sept. 11, 2020, 7:53 a.m.
acezar created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  A facade to `Revlog` to provide a `changelog` specific interface.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D9010

AFFECTED FILES
  rust/hg-core/src/revlog.rs
  rust/hg-core/src/revlog/changelog.rs

CHANGE DETAILS




To: acezar, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/rust/hg-core/src/revlog/changelog.rs b/rust/hg-core/src/revlog/changelog.rs
new file mode 100644
--- /dev/null
+++ b/rust/hg-core/src/revlog/changelog.rs
@@ -0,0 +1,58 @@ 
+use crate::revlog::revlog::{Revlog, RevlogError};
+use crate::revlog::Revision;
+use std::path::PathBuf;
+
+/// A specialized `Revlog` to work with `changelog` data format.
+pub struct Changelog {
+    /// The generic `revlog` format.
+    revlog: Revlog,
+}
+
+impl Changelog {
+    /// Open the `changelog` of a repository given by its root.
+    pub fn open(root: &PathBuf) -> Result<Self, RevlogError> {
+        let index_file = root.join(".hg/store/00changelog.i");
+        let revlog = Revlog::open(&index_file)?;
+        Ok(Self { revlog })
+    }
+
+    /// Return the `ChangelogEntry` a given node id.
+    pub fn get_node(
+        &self,
+        node: &[u8],
+    ) -> Result<ChangelogEntry, RevlogError> {
+        let rev = self.revlog.get_node_rev(node)?;
+        self.get_rev(rev)
+    }
+
+    /// Return the `ChangelogEntry` of a given node revision.
+    pub fn get_rev(
+        &self,
+        rev: Revision,
+    ) -> Result<ChangelogEntry, RevlogError> {
+        let bytes = self.revlog.get_rev_data(rev)?;
+        Ok(ChangelogEntry { bytes })
+    }
+}
+
+/// `Changelog` entry which know how to interpret the `changelog` data bytes.
+#[derive(Debug)]
+pub struct ChangelogEntry {
+    /// The data bytes of the `changelog` entry.
+    bytes: Vec<u8>,
+}
+
+impl ChangelogEntry {
+    /// Return an iterator over the lines of the entry.
+    pub fn lines(&self) -> impl Iterator<Item = &[u8]> {
+        self.bytes
+            .split(|b| b == &b'\n')
+            .filter(|line| !line.is_empty())
+    }
+
+    /// Return the node id of the `manifest` referenced by this `changelog`
+    /// entry.
+    pub fn manifest_node(&self) -> Result<&[u8], RevlogError> {
+        self.lines().next().ok_or_else(|| RevlogError::Corrupted)
+    }
+}
diff --git a/rust/hg-core/src/revlog.rs b/rust/hg-core/src/revlog.rs
--- a/rust/hg-core/src/revlog.rs
+++ b/rust/hg-core/src/revlog.rs
@@ -8,6 +8,7 @@ 
 pub mod node;
 pub mod nodemap;
 pub use node::{Node, NodeError, NodePrefix, NodePrefixRef};
+pub mod changelog;
 pub mod index;
 pub mod patch;
 pub mod revlog;