Patchwork git: remove unrequired assignment of listignored and listunknown

login
register
mail settings
Submitter Pulkit Goyal
Date Sept. 10, 2020, 11:34 a.m.
Message ID <bb9c58334a8313684c02.1599737664@workspace>
Download mbox | patch
Permalink /patch/47125/
State Accepted
Headers show

Comments

Pulkit Goyal - Sept. 10, 2020, 11:34 a.m.
# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1599737618 -19800
#      Thu Sep 10 17:03:38 2020 +0530
# Node ID bb9c58334a8313684c023e87321095b5a94fa2a1
# Parent  e47385ef4e1713a95db194bde7e28461fd8d987b
# EXP-Topic test-fixes
git: remove unrequired assignment of listignored and listunknown

Caught by test-check-pyflakes.t
Yuya Nishihara - Sept. 11, 2020, 12:25 a.m.
On Thu, 10 Sep 2020 17:04:24 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1599737618 -19800
> #      Thu Sep 10 17:03:38 2020 +0530
> # Node ID bb9c58334a8313684c023e87321095b5a94fa2a1
> # Parent  e47385ef4e1713a95db194bde7e28461fd8d987b
> # EXP-Topic test-fixes
> git: remove unrequired assignment of listignored and listunknown

Queued, thanks.

Patch

diff --git a/hgext/git/dirstate.py b/hgext/git/dirstate.py
--- a/hgext/git/dirstate.py
+++ b/hgext/git/dirstate.py
@@ -129,7 +129,7 @@  class gitdirstate(object):
             return False
 
     def status(self, match, subrepos, ignored, clean, unknown):
-        listignored, listclean, listunknown = ignored, clean, unknown
+        listclean = clean
         # TODO handling of clean files - can we get that from git.status()?
         modified, added, removed, deleted, unknown, ignored, clean = (
             [],