From patchwork Mon Sep 7 21:30:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D8992: git: restore basic functionality after b3040b6739ce From: phabricator X-Patchwork-Id: 47101 Message-Id: To: Phabricator Cc: mercurial-devel@mercurial-scm.org Date: Mon, 7 Sep 2020 21:30:53 +0000 durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We don't yet have a formal interface for the changelog, but it's mostly specified. Sadly, b3040b6739ce added a semi-private pseudo-enum that we need to cope with, so it's probably high time that someone (me?) attempts to define that interface to prevent future backsliding. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8992 AFFECTED FILES hgext/git/gitlog.py CHANGE DETAILS To: durin42, #hg-reviewers Cc: mercurial-patches, mercurial-devel diff --git a/hgext/git/gitlog.py b/hgext/git/gitlog.py --- a/hgext/git/gitlog.py +++ b/hgext/git/gitlog.py @@ -96,6 +96,10 @@ # TODO: an interface for the changelog type? class changelog(baselog): + # TODO: this appears to be an enumerated type, and should probably + # be part of the public changelog interface + _copiesstorage = b'extra' + def __contains__(self, rev): try: self.node(rev)