Patchwork D8992: git: restore basic functionality after b3040b6739ce

login
register
mail settings
Submitter phabricator
Date Sept. 7, 2020, 9:30 p.m.
Message ID <differential-rev-PHID-DREV-7vmnmnflqogoy2twndnp-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/47101/
State Superseded
Headers show

Comments

phabricator - Sept. 7, 2020, 9:30 p.m.
durin42 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We don't yet have a formal interface for the changelog, but it's
  mostly specified. Sadly, b3040b6739ce <https://phab.mercurial-scm.org/rHGb3040b6739ce4773ac02607604bc5875102167e2> added a semi-private pseudo-enum
  that we need to cope with, so it's probably high time that someone
  (me?) attempts to define that interface to prevent future backsliding.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8992

AFFECTED FILES
  hgext/git/gitlog.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/hgext/git/gitlog.py b/hgext/git/gitlog.py
--- a/hgext/git/gitlog.py
+++ b/hgext/git/gitlog.py
@@ -96,6 +96,10 @@ 
 
 # TODO: an interface for the changelog type?
 class changelog(baselog):
+    # TODO: this appears to be an enumerated type, and should probably
+    # be part of the public changelog interface
+    _copiesstorage = b'extra'
+
     def __contains__(self, rev):
         try:
             self.node(rev)